ENGAGE-307: Implement the "Save and send my collection to me button" in My Collection

Description

For Engage 0.3 beta, we will implement this "send my collection" action as a simple POST request to an external script. Hugues is implementing a script that will accept the user's email address, language selection, and their personal collection as parameters. He will then merge the collection with the user information in his CMS and send an email to the user.

Here's an email thread on fluid-work about how to implement it:

http://old.nabble.com/My-Collection%3A-what-should-happen-after-the-user-gives-their-email--address-td27468683.html

Attachments

• ENGAGE-307core.patch
• ENGAGE-307-core.patch.txt
• ENGAGE-307kettle.patch
• ENGAGE-307-kettle.patch.txt
• 

Comments

• Michelle D'Souza commented 2010-02-02T10:18:27.000-0500

  mccord-pilot

• Colin Clark commented 2010-02-08T16:09:25.000-0500

  Bug Parade Engage 0.3

• Colin Clark commented 2010-02-08T17:11:44.000-0500

  Sveto, since I'm still in the midst of getting My Collection working before merging it into trunk, you may want to submit these fixes as patches to make it easier to apply them.

• Justin Obara commented 2010-02-18T21:10:22.000-0500

  Attaching two new patches after my code review of the yura/sveto patch

  The unit tests are still broken though.

• Colin Clark commented 2010-02-19T00:20:04.000-0500

  I have committed a modified version of the patch that Yura and Justin submitted on this ticket. A couple of things to note in the future, Yura/Justin/Sveto:

  1. Don't forget the Same Origin Policy: you can't POST via AJAX in the browser to a different server
  2. Writing a service that will blindly POST to any URL specified in the query parameters is a security flaw
  3. HTTP semantics matter. Don't GET when you should be POSTing

  I modified the server-side code to read the sendMyCollectionURL out of Engage's config file, rather than accepting it as a request parameter. I have not yet changed the client-side code to do a POST instead of a GET. That'll have to happen for 0.3 final.

  I'm also not fully convinced that a jQuery UI Dialog is the most optimal solution here. It works, but it's going to be slow on a mobile phone. Given Safari's lack of support for most ARIA roles, it may also not be the most accessible option.

• Colin Clark commented 2010-02-19T00:20:33.000-0500

  I've reviewed and committed this code. Issues found during the review will be filed as separate, non-blocker bugs.