FLUID-1250: Reorderer - drop marker hide() and show() are too presumptuous

Metadata

Source
FLUID-1250
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Jacob Farber
Created
2008-08-20T11:52:45.000-0400
Updated
2011-02-22T16:27:50.764-0500
Versions
  1. 0.5beta1
Fixed Versions
  1. 0.5
Component
  1. Reorderer

Description

When manipulating the drop marker, using jQuery's show() method sets the display property to "block", which breaks layouts that require things to be displayed inline.
An alternative is to not use show() and hide(), rather remove and inject the drop marker as needed, allowing existing CSS declarations handle the display type.

Comments

  • Antranig Basman commented 2008-09-07T18:42:47.000-0400

    Fixed at revision 5478

  • Jacob Farber commented 2008-09-17T12:28:31.000-0400

    Antranig and I exhaustively analyzed what hide() and show() do in action.
    It seems the computed style of an element in creation is fine (for an LI it was display:list-item) yet that gets converted into display:block somwhere before being injected into the DOM and therefore jQuery keeps using display:block, which isnt correct.

    The solution in the meantime is to use $(el).css("display","") to reveal the drop marker until we can figure out how this happens and how to avoid it.
    Thats my best guess.

  • Michelle D'Souza commented 2011-02-22T16:27:50.762-0500

    Closing issues that were resolved for 1.0 and earlier releases.