FLUID-1935: Consolidate Uploader.css and infusion-theme.css with the Fluid Skinning System.

Description

At the moment, Uploader uses a different set of conventions for CSS classes, calling the namespace "fluid-" instead of "fl-." We also have a file called infusion-theme.css which could be confused with the other themes we've got. Let's consolidate the Uploader's CSS with the skinning system.

Attachments

• FLUID-1935.patch
• FLUID-1935-just-css-file.patch

Comments

• Justin Obara commented 2008-12-08T10:44:29.000-0500

  Bug Parade 0.6 release

• Eli Cochran commented 2008-12-12T12:25:36.000-0500

  This is a pretty big patch that touches a number of files including tests. Note I also need to make sure that the server version is working but since that is another code-base, any changes to that will be in another patch.

• Eli Cochran commented 2008-12-12T13:16:37.000-0500

  For some reason the new fluid.components.uploader.css file was not coming through in the patch. This is just that file.

• Anastasia Cheetham commented 2008-12-12T17:19:59.000-0500

  I'm seeing some inconsistency in naming of styles for components. The uploader styles all start with "fl-uploader-" i.e. "fl-" followed by the component name (see fluid.components.uploader.css).

  But other components use style names that start with the component name i.e. there is no "fl-" prefix (e.g. "ui_options_container" and "ui-dialog" and "inlineEdit-invitation" and "orderable-*")

  Should we decide on a convention and stick to it, or was there a reason for the existing scheme?

• Eli Cochran commented 2008-12-15T12:22:47.000-0500

  I'm marking this fixed. There is certainly other tweaking that could be done to improve this integration but for the moment the CSS is consistent, we've removed a file, and significantly tightened up another. I am happy.

• Eli Cochran commented 2008-12-15T14:22:39.000-0500

  Three problems were introduced in the refactoring of the CSS, both of which only appear in the Uploader Springboard.

  While the springboard uses it's own CSS declaration, it was brought into line with the new selectors. Otherwise we would have had to override every selector in the springboard initter. (Which would have been a great test but for another time.)

  The three bugs are:

  • the Uploader would fail on init. Caused by more than one fl-uploader-queue object in markup.
  • Remove buttons not working, because the selector had changed
  • Row template in the second example being visible. This one puzzles me... this markup didn't change

• Eli Cochran commented 2008-12-15T14:32:31.000-0500

  New patch with fixes for the three problems listed above. Plus some detabbifying just to make it hard to see what's what 😉

• Eli Cochran commented 2008-12-15T18:06:55.000-0500

  Moving Springboard problems to there own JIRA (FLUID-1980).

• Eli Cochran commented 2008-12-15T18:09:11.000-0500

  I removed the FLUID-1935.b.patch file because it is no longer part of this JIRA and is now superseded by the patch attached to FLUID-1980