FLUID-2416: flashURL option ignored in swfUploadSetupDecorator (browse button does not display)

Description

In Uploader for v0.8, flash9URL and flash10URL are generally deprecated. In practice the swfUploadSetupDecorator object, which dictates the settings for the Browse button, still references flashXXURL options and ignores the new flashURL option.

Result: the Browse flash movie always uses the default flash_url of "../../flash/swfupload.swf", no matter how flashURL is set.

Workaround: for the time being, the problem can be avoided by defining a flashXXURL option on the decorator:
decorators: {
type: "fluid.swfUploadSetupDecorator",
options: {
// This option points to the location of the Browse Files button used with Flash 10 clients.
flashButtonImageURL: "js/fluid/fluid-components/images/uploader/browse.png",
flash9URL: "js/fluid/fluid-components/flash/swfupload.swf",
flash10URL: "js/fluid/fluid-components/flash/swfupload.swf"
}
}

Code: see SWFUploadManager.js lines 138, 106, 72.

Note 1: Defining a "flashURL" option inside the decorator is not sufficient - the code only looks for flash(9|10)URL before falling back to the default value.

Note 2: This problem may not be apparent in the distributed test files for the Uploader where all files are correctly located relative to one another for the default path to work. Confirm problem by setting a new flashURL value and placing swfupload.swf in the new location or else or simply viewing the generated flash object code to see that the default value is always used for "data='...'" regardless of the current value of "flashURL".

Note 3: I'm a new bug submitter, and wasn't sure what severity to assign. I opted for "minor" given the easy workaround, but fluid admins may wish to adjust. My apologies if this issue has already been resolved in version 1.0.

Environments

Linux (Ubuntu 8.10), Firefox 3.0.7, Flash 10.x

Comments

• Aaron Brown commented 2009-03-26T16:44:44.000-0400

  Correction: This may not in fact be a real issue. I have found that by declaring the flashURL option in a different way, the Browse button loads as it should. It appears to me that this is actually a bug :question: in the sample code provided in the wiki tutorial, not in the javascript. My apologies.

  Solution:
  Wiki tutorial says:
  var myUpload = new fluid.progressiveEnhanceableUploader(".fl-uploader", ".fl-progressive-enhanceable", {
  uploadManager: {
  // Set the uploadURL to the URL for posting files to your server.
  uploadURL: "http://myserver.com/uploadFiles",

  // This option points to the location of the SWFUpload Flash object that ships with Fluid Infusion.
  flashURL: "fluid-1.0/fluid-components/swfupload/swfupload.swf"
  },
  // ... [snip] ...

  As written, the uploadManager options are ignored. When uploadURL and flashURL are enclosed in an "options" hash, all works as intended.

  Quick fix that should probably be cleaned up:
  var myUpload = new fluid.progressiveEnhanceableUploader(".fl-uploader", ".fl-progressive-enhanceable", {
  uploadManager: {
  options: {
  // Set the uploadURL to the URL for posting files to your server.
  uploadURL: "http://myserver.com/uploadFiles",

  // This option points to the location of the SWFUpload Flash object that ships with Fluid Infusion.
  flashURL: "fluid-1.0/fluid-components/swfupload/swfupload.swf"
  }
  },
  // ... [snip] ...

• Justin Obara commented 2009-05-05T13:30:45.000-0400

  The tutorial appears to have been updated