FLUID-2590: flc-reorderer-dropWarning used for both DOM selection and styling

Metadata

Source
FLUID-2590
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Justin Obara
Created
2009-04-13T11:34:35.000-0400
Updated
2009-08-04T09:56:00.000-0400
Versions
  1. 1.0
  2. 1.1
Fixed Versions
  1. 1.1.1
  2. 1.2
Component
  1. Layout Reorderer

Description

flc-reorderer-dropWarning used for both DOM selection and styling

The flc- prefix is meant only for DOM Selection. Another class with an fl- prefix should be created for use with css styling

Environments

FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
Safari 3.2 (Mac OS 10.4)
FF2, FF3, IE6, IE7, IE8, Opera 9.6 (Win XP)
FF3, IE7, IE8 (Win Vista)
IE6 (Win 2000)

Comments

  • Justin Obara commented 2009-07-27T16:26:59.000-0400

    Bug Parade 1.1.1 release

  • Justin Obara commented 2009-07-28T15:01:23.000-0400

    changed the css class from flc-reorderer-dropWarning to fl-reorderer-dropWarning and added this new class name into the markup for the demos

  • Michelle D'Souza commented 2009-07-31T14:16:33.000-0400

    I think we should put the styling back on the flc-reorderer-dropWarning class so that if people upgrade to 1.1.1 they don't need to change their markup. The full change is fine for 1.2

  • Justin Obara commented 2009-07-31T14:24:19.000-0400

    added the flc-reorderer-dropWarning stying back into 1.1.1 along side the fl-reorderer-dropWarning with a note to its deprication in 1.2

  • Michelle D'Souza commented 2009-07-31T15:24:56.000-0400

    I code reviewed this issue

  • Justin Obara commented 2009-08-04T09:56:00.000-0400

    Verified fix using:

    FF3, IE 7 (Win Vista)
    FF3.5, FF2, Safari 3, Opera 9.6 (Mac OS 10.5)