FLUID-4562: UIO settings saved in the cookie are discarded once quit the browser

Metadata

Source
FLUID-4562
Type
Bug
Priority
Critical
Status
Open
Resolution
N/A
Assignee
N/A
Reporter
Cindy Li
Created
2011-11-29T14:54:50.653-0500
Updated
2017-09-26T12:41:03.903-0400
Versions
  1. 1.4
  2. 1.5
  3. 2.0
Fixed Versions
N/A
Component
  1. Prefs Framework
  2. UI Options

Description

The bug report from Jonny:

"On my site <http://abledaccess.com> when I change the display setting via uiOptions in the latest versions of Safari, Chrome, Opera and IE, then quit each browser, my settings I set have been reset. Same goes with your demo across said browsers, as well. I saw on Colin's computer this behaviour doesn't happen in Firefox, but it happens on my machine in Firefox, as well. But the reset did happen in Safari, Chrome and Opera on his computer. "

Environments

Safari, Chrome, Opera and sometimes firefox

Comments

  • Cindy Li commented 2011-11-29T14:55:19.335-0500

    The issue seems a result of our improper default value for the cookie "expiry" attribute, which is blank by default:

    https://github.com/fluid-project/infusion/blob/master/src/webapp/components/uiOptions/js/Store.js#L60

    According to http://www.tutorialspoint.com/javascript/javascript_cookies.htm, which says,

    Expires : The date the cookie will expire. If this is blank, the cookie will expire when the visitor quits the browser.

    So, a blank default apparently is not enough if what we meant is to keep the user-selected settings forever. We probably should consider to have a default expiry value of 50 years from now.

  • Justin Obara commented 2015-06-10T13:53:47.018-0400

    I'm not really sure what we want the default to be for the cookie expiration.

    • browser quit
    • some number of days
    • forever
    • etc.

    Dana and Jonathan Hung did you have any thoughts?