FLUID-4692: Faulty sentinelization in Layout Reorderer causes failure in layouts with multiple rows "against the grain"

Metadata

Source
FLUID-4692
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Antranig Basman
Reporter
Antranig Basman
Created
2012-04-08T23:02:58.369-0400
Updated
2014-03-03T12:55:44.953-0500
Versions
  1. 1.3
  2. 1.4
Fixed Versions
  1. 1.5
Component
  1. Layout Reorderer
  2. Reorderer

Description

The "sentinelization" algorithm introduced to resolve FLUID-1589 does not deal with complex cases correctly. It makes the assumption that there is simple structure in the DOM layout perpendicular to the "dominant direction". For example, in the vertical orientation of the layout reorderer, if there are multiple sets of modules with the same horizontal coordinates, the "sentinel zones" for the cells within the modules at the extremes of the zones will overlap, causing many of them not to be findable either when dragging with the mouse or keyboard. This issue was probably noticed a while ago, but in that case it was triggered by a separate bug involving the orientation of the layout being set incorrectly. Now a user has selected one of these complex layouts, the failure is observable in normal operation.

The sentinelization algorithm needs to be fixed to cull sentinel zones which intersect other cells.

Comments

  • Michelle D'Souza commented 2012-05-03T06:31:04.701-0400

    Merged into project repo at 4ae57474202ef1020efad64709079659974d7122