Metadata
- Source
- FLUID-5207
- Type
- Improvement
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Justin Obara
- Reporter
- Anastasia Cheetham
- Created
2013-11-06T12:45:58.632-0500 - Updated
2014-04-24T16:20:55.770-0400 - Versions
- N/A
- Fixed Versions
-
- 1.5
- Component
-
- Prefs Framework
Description
A panel component in the prefs framework now has two properties: "msgBundle" and "stringBundle." These two names are awfully similar – at a glance, there's no clue as to what the difference is. We expect integrators to be working with these properties, so it would probably be helpful to them if the properties were renamed to something a bit clearer.
"msgBundle" is actually a messageResolver component, so perhaps "msgResolver" ?
"stringBundle" is a tool to facilitate using the msgBundle; Not sure yet what to call this, but I'll think on it.
Comments
-
Michelle D'Souza commented
2014-04-04T15:51:34.526-0400 Anastasia Cheetham, can you please start a conversation on list about naming these?
-
Justin Obara commented
2014-04-24T14:57:45.908-0400 Based on the conversation in the channel today https://botbot.me/freenode/fluid-work/2014-04-24/?tz=America/Toronto
"msgBundle" -> "msgResolver"
"stringBundle" -> "msgLookup" -
Justin Obara commented
2014-04-24T15:42:04.421-0400 Submitted a pull request
https://github.com/fluid-project/infusion/pull/498 -
Cindy Li commented
2014-04-24T16:20:49.321-0400 Merged into the project repo @ 78d3600b61697a5063f066735b3943dfbab1b1b9