FLUID-5260: Minification strips quotes from "true" and "false" keys; breaks IE8

Metadata

Source
FLUID-5260
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Anastasia Cheetham
Created
2014-01-27T12:19:16.804-0500
Updated
2014-02-14T13:12:35.083-0500
Versions
N/A
Fixed Versions
  1. 1.5
Component
  1. Build Scripts

Description

The ModelTransformation code has an object that uses "true" and "false" as keys:

fluid.defaults("fluid.transforms.condition", {
gradeNames: [ "fluid.multiInputTransformFunction", "fluid.standardOutputTransformFunction" ],
inputVariables: {
"true": null,
"false": null,
"condition": null
}
});

For some reason, the minification process strips the quotes from the keys in this object, and the resulting JS causes an error in IE8, "Expected identifier, string or number" and the entire file fails to load, leading to fluid undefined, jquery undefined, etc.

Comments

  • Justin Obara commented 2014-02-14T13:12:32.189-0500

    Fixed with changes for FLUID-5120 that switched to using grunt for build tasks.