FLUID-5822: Remove requirement to "dedupe" multiple infusions within a module tree

Metadata

Source
FLUID-5822
Type
Improvement
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Antranig Basman
Reporter
Antranig Basman
Created
2015-11-30T12:44:11.123-0500
Updated
2017-03-01T20:46:03.251-0500
Versions
N/A
Fixed Versions
N/A
Component
  1. Framework

Description

Shower time of recent weeks has suggested that it ought to be possible to eliminate the requirement to "dedupe" multiple instances of Infusion from a module tree, by means of some semi-ingenious behaviour at module load time. Scribbling on pieces of paper suggests that issuing node's "resolve" algorithm for the directory 3 levels in the hierarchy above the current Infusion's root should pick up any infusion resolvable by outer scoped modules. If we find such a n Infusion, we can just assign it to module.exports and return - and the same algorithm will cascade hierarchically. If we find no such infusion, we must be the highest, and proceed with normal initialisation.

Comments

  • Antranig Basman commented 2016-01-13T10:42:42.307-0500

    Reopened since only the 1.9.x version of this pull has been merged

  • Justin Obara commented 2016-01-15T11:59:54.362-0500

    Merged pull request ( https://github.com/fluid-project/infusion/pull/654 ) into the project repo at 4e1b8c9a64665c67232901d2e57531926ec7247f and 2f38c09d733925441f0ff2e6636f8886da8af5ea