FLUID-5901: jqUnit.assertDeepEq will compare all primitive values as equal

Metadata

Source
FLUID-5901
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Antranig Basman
Reporter
Antranig Basman
Created
2016-05-03T21:28:39.845-0400
Updated
2016-05-04T16:32:44.778-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Testing Infrastructure

Description

The algorithm applied by jqUnit.assertDeepEq (ultimately punching through to QUnit.propEqual) will consider all primitive values as equivalent, which is incredibly unhelpful. This caused significant problems with https://github.com/GPII/windows/pull/59 where this utility was mistakenly used to consider that true was equal to false. We need to adjust this implementation to give sensible results in these cases.

Comments