Metadata
- Source
- SJRK-264
- Type
- Improvement
- Priority
- Major
- Status
- Open
- Resolution
- N/A
- Assignee
- N/A
- Reporter
- Gregor Moss
- Created
2019-07-29T17:34:01.931-0400 - Updated
2020-01-24T13:31:54.938-0500 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- Storytelling Tool Server
- Storytelling Tool UI
Description
Remove the "baseTheme" key from the clientConfig values returned by sjrk.storyTelling.server.getClientConfig()
This relates very closely and perhaps could be solved by the work outlined in SJRK-256, and it may remove the need for sjrk.storyTelling.loadCustomThemeFiles()
Comments
-
Gregor Moss commented
2020-01-24T13:31:54.938-0500 This would should not include what is in SJRK-256's scope. The aim is to remove this one extra value which, at time of writing, is essentially only used to determine whether to load custom theme files. The work in SJRK-265/SJRK-230 will likely affect this.
A quick solve could be to check for truthiness of clientConfig.theme rather than comparing it against a baseTheme value.